authproxy connector: add support for specifying group header separator #3745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allows using separators other than , to split groups Signed-off-by: a-buck <5923598+a-buck@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This change proposes making the group header splitter configurable so a value other than
,can be used.What this PR does / why we need it
Motivated as the groups header is not universally a
,. For example the default group separator in mod_auth_mellon is;.This change intends to be fully backwards compatible. I also refactored the tests slightly to exercise more of the production code and reduce duplication.
Please let me know if you have any feedback, more than happy to address any items.