Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create offline sessions if approval is skipped #3828

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

nabokihms
Copy link
Member

Overview

Offline session is not created if the skip approval option is toggled. In this case Dex looses connector data and cannot refresh tokens.

It leads to the different refreshing errors in logs like:

{"time":"2024-11-06T10:19:31.541474938Z","level":"ERROR","msg":"failed to refresh identity","err":"gitlab: failed to get refresh token: oauth2: \"invalid_grant\" \"The provided authorization grant is invalid, expired, revoked, does not match the redirection URI used in the authorization request, or was issued to another client.\"","client_remote_addr":"10.244.28.54","request_id":"8e46b1aa-3bd2-4ef1-a844-ad0db91dbc1e"}

What this PR does / why we need it

This PR adjust the part of the code to make it creating and updating connectorData when it is needed avoiding refresh errors.

Special notes for your reviewer

Signed-off-by: maksim.nabokikh <max.nabokih@gmail.com>
@nabokihms nabokihms merged commit bb985ca into dexidp:master Nov 25, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants