Remove old client_resource api #468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
June 15, 2016 11:42
The only thing using this AFAIK is dexctl in api_driver mode, which no-one uses - it's a sort of weird API which requires a client to create other clients, and gives all clients the ability to list all other clients. So we are removing it.
...and dependent code.
API Driver is dead: This API turns out to not be super useful, requiring an existing client to create other clients is weird. Long live API Driver? Let's use Dynamic Client API and the bootstrap API to create a better API Driver! LONG LIVE API DRIVER.
|
Looks like a flake. Retesting. |
|
Never mind. The tests are indeed failing on go 1.5.4. |
go 1.5.4 accepts just about anything as a URL, so instead just trigger with blank URL
|
lgtm |
|
w00t thanks |
|
Delete all the code! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also remove dexctl api_driver
fixes #467