Implement Public Clients #471
Conversation
|
|
||
| err := cli.Metadata.Valid() | ||
| if err != nil { | ||
| fmt.Println("manager throwing validation error") |
There was a problem hiding this comment.
left over log statement
There was a problem hiding this comment.
WIP Means work in progress :)
bobbyrullo
force-pushed
the
native
branch
2 times, most recently
from
304bf66 to
89280b1
Compare
bobbyrullo
force-pushed
the
native
branch
2 times, most recently
from
bdbf96c to
cb207e7
Compare
bobbyrullo
changed the title
|
Got a vet error |
|
|
||
| err := cli.Metadata.Valid() | ||
| if err != nil { | ||
| return client.ValidationError{err} |
There was a problem hiding this comment.
This is the vet error btw. Needs to be client.ValidationError{Err:err}
There was a problem hiding this comment.
yeah, I just don't know why mine didn't catch it.
| @@ -165,6 +163,12 @@ func (a *AdminAPI) GetConnectors() ([]connector.ConnectorConfig, error) { | |||
| } | |||
|
|
|||
| func mapError(e error) error { | |||
| switch t := e.(type) { | |||
| case client.ValidationError: | |||
There was a problem hiding this comment.
I really dislike type switching for a specific error since it makes the validateClient code really brittle. Would be nice if this was formalized more, such as introducing HTTP specific error behavior. I suppose that's outside of the scope of this PR though.
There was a problem hiding this comment.
Would it help if I documented manager.New() as to which errors can be returned?
There was a problem hiding this comment.
Maybe put it on ValidationError? Whichever works best. If it's tested that might be enough.
* validation of client moved into its own method and tested * public clients have different validation - must have no redirect URIs and must have a clientName set
* Start Documentation
and update docs
Metadata is not enough these days - we're going to need access to the Public field as well.
* disallow ClientCreds for public clients * clients can only redirect to localhost or OOB
When calling manager.Authenticate, logs now show different error messages.
When "urn:ietf:wg:oauth:2.0:oob" is used as a redirect URI, redirect to an internal dex page where the user is shown the code and instructed to paste it into their app.
fixes #469