*: depricate --email-from flag and move to email config files #487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems to work. Ready for review @sym3tri |
| @@ -20,6 +20,7 @@ set `auth` to `plain` and specify your username and password. | |||
| "host": "smtp.example.org", | |||
| "port": 587, | |||
| "auth": "plain", | |||
There was a problem hiding this comment.
While you're in here can you make this field not required. Currently if it's omitted Dex explodes, but we only support 'plain' and a default. Let's just default to the default if it's not provided.
There was a problem hiding this comment.
Changed this to use auth if "username" and "password" fields are provided.
Also going to let the port be provided in the "host" field.
|
LGTM |
Use "plain" auth if and only if username and password are provided. Parse port from "host" field if it's provided.
|
Since all changes are backward compatible I'm going to merge unless there are objections. cc @sym3tri |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still need to test with a full installation.
Closes #389