refresh token rotation #540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| expectedAud []string | ||
| err error | ||
| token string | ||
| expectedRefreshToken string |
There was a problem hiding this comment.
How are you coming up with these values? Can you implement a helper function to do this?
|
A few comments, but overall looks good. Thanks! |
rsoletob
force-pushed
the
519-refresh-token-only-work-once
branch
from
4d27176 to
804abd1
Compare
|
Thanks for your comments. I see an user could have some refresh tokens for the same client and there is a TODO. Is it correct? I can change it here or in another PR if you think it isn't a valid feature. |
|
Probably best for a different PR :) |
|
Ok @ericchiang, revamped |
|
|
||
| func (r *refreshTokenRepo) RenewRefreshToken(clientID, userID, oldToken string) (newRefreshToken string, err error) { | ||
| // Verify | ||
| userID, connectorID, scopes, err := r.verify(nil, clientID, oldToken) |
There was a problem hiding this comment.
Why is verify outside the transaction?
There was a problem hiding this comment.
Because if dex can't verify the token you save opening a transaction.
|
small nit but other than that tested locally and lgtm |
Update refresh token flow to revoke old refresh token and generates a new one. Fixes dexidp#519
rsoletob
force-pushed
the
519-refresh-token-only-work-once
branch
from
804abd1 to
c91b37a
Compare
|
lgtm! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added refresh token rotation.
Fixes #519