*: add 'make revendor' and tests to catch incorrect glide usage #756
Conversation
| @@ -35,6 +35,11 @@ bin/example-app: check-go-version | |||
| release-binary: | |||
| @go build -o _output/bin/dex -v -ldflags $(LD_FLAGS) $(REPO_PATH)/cmd/dex | |||
|
|
|||
| .PHONY: revendor | |||
| revendor: | |||
There was a problem hiding this comment.
Might be worth checking the version of glide used too, if you're trying to catch mistakes.
There was a problem hiding this comment.
This is kinda already addressed in our documentation.
Dex uses glide and glide-vc to manage its vendor directory. A recent version of these are preferred but dex doesn't require any bleeding edge features. Either install these tools using go get or take an opportunity to update to a more recent version.
If we ever need something that was added in a specific version of glide we can add a script similar to scripts/check-go-version, but I don't really want to write a bunch of sed commands right now :/
Introducing glide-vc caused us to unknowingly removed our Go protobuf compiler (since it's a main). Add flags to glide-vc usage to remedy this. Since we now require several glide and glide-vc flags, add a Makfile target and tests to catch when PRs don't use the correct flags.
| t.Fatalf(".git directory detected in vendor: %s. Revendor packages using 'make revendor' to use the correct glide and glide-vc flags", path) | ||
| } | ||
| if !info.IsDir() && strings.HasSuffix(path, "_test.go") { | ||
| t.Fatalf("'_test.go' file detected in vendor: %s. Revendor packages using 'make revendor' to use the correct glide and glide-vc flags", path) |
There was a problem hiding this comment.
Is this so we avoid vendors from introducing their own tests into our code?
There was a problem hiding this comment.
Yep. glide-vc has a mode that deletes all test files from the vendor directory. We don't run those tests anyway, so there's no good reason to hold onto them.
|
lgtm |
Introducing glide-vc caused us to unknowingly removed our Go protobuf
compiler (since it's a main). Add flags to glide-vc usage to remedy
this.
Since we now require several glide and glide-vc flags, add a Makfile
target and tests to catch when PRs don't use the correct flags.
cc @rithujohn191