Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

connector/ldap: don't query for groups if no base DN is provided #758

Closed
wants to merge 1 commit into from

Conversation

ericchiang
Copy link
Contributor

No description provided.

@@ -445,6 +445,11 @@ func (c *ldapConnector) Refresh(ctx context.Context, s connector.Scopes, ident c
}

func (c *ldapConnector) groups(ctx context.Context, user ldap.Entry) ([]string, error) {
if c.GroupSearch.BaseDN == "" {
c.logger.Infof("groups requested but no baseDN provided")
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What would a support person or user do with this information and how they would find information to rectify if this is not their desired configuration? Perhaps:

"No groups returned for ${username} because no groups baseDN has been configured"

Plus, how often will this log line be printed out? On every login?

@ericchiang
Copy link
Contributor Author

ericchiang commented Dec 27, 2016 via email

@rithujohn191
Copy link
Contributor

On it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants