examples: adding a gRPC client example. #812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rithujohn191
force-pushed
the
example-client
branch
from
c37a6e3 to
e0aca1f
Compare
ericchiang
reviewed
Feb 23, 2017
examples/grpc-client/client.go
Outdated
| } | ||
|
|
||
| func main() { | ||
| var caCrt = flag.String("ca_crt", "", "CA certificate") |
There was a problem hiding this comment.
nit: we generally use "-" in flags instead of "_"
Also the var is redundant. You can just do "caCert := flag.String"
ericchiang
reviewed
Feb 23, 2017
| @@ -0,0 +1,81 @@ | |||
| # OpenSSL configuration file. | |||
There was a problem hiding this comment.
Where's this from? Unless you wrote it yourself, please add a comment about its origin.
ericchiang
reviewed
Feb 23, 2017
examples/grpc-client/README.md
Outdated
| Finally run the Dex client providing the CA certificate, client certificate and client key as arguments. | ||
|
|
||
| ``` | ||
| ./grpc-client -ca_crt=ca.crt -client_crt=client.crt -client_key=client.key |
ericchiang
reviewed
Feb 23, 2017
| @@ -0,0 +1,4 @@ | |||
| #!/bin/bash | |||
There was a problem hiding this comment.
Please add a .gitignore file to ignore the certs and keys too.
ericchiang
reviewed
Feb 23, 2017
rithujohn191
force-pushed
the
example-client
branch
from
e0aca1f to
0816431
Compare
|
Addressed all your suggestions 👍 |
rithujohn191
force-pushed
the
example-client
branch
from
0816431 to
c0d5235
Compare
|
Link in Documentation/api.md? |
|
Theres a line that says "For further details on the Dex API refer [ |
rithujohn191
force-pushed
the
example-client
branch
from
c0d5235 to
fa2f76b
Compare
|
Also added the link to this client example in Documentation/api.md. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The example program implements a Dex client that makes gRPC API calls to create, list and delete passwords.