*: validate InResponseTo SAML response field and make issuer optional #869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericchiang
force-pushed
the
saml-response-to
branch
from
c46b875 to
cb59817
Compare
|
Tested this change with Okta :+1. The instructions are great! thanks. |
rithujohn191
approved these changes
Mar 22, 2017
connector/saml/saml_test.go
Outdated
| defaultRedirectURI = "http://localhost:5556/dex/callback" | ||
| responseID = "_fd1b3ef9-ec09-44a7-a66b-0d39c250f6a0" |
There was a problem hiding this comment.
Maybe add a note where this value came from?
ericchiang
force-pushed
the
saml-response-to
branch
from
cb59817 to
50b223a
Compare
mmrath
pushed a commit
to mmrath/dex
that referenced
this pull request
Sep 2, 2019
*: validate InResponseTo SAML response field and make issuer optional
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.