Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spacing around markdown links #60

Open
nate-double-u opened this issue Oct 22, 2020 · 4 comments
Open

Spacing around markdown links #60

nate-double-u opened this issue Oct 22, 2020 · 4 comments
Labels
bug Something isn't working

Comments

@nate-double-u
Copy link
Contributor

nate-double-u commented Oct 22, 2020

It looks like there is space being added around links, causing some punctuation to be incorrectly spaced.

Using the Getting Started page to illustrate:

This code:
Screen Shot 2020-10-22 at 10 59 43 AM

Generates this output:
Screen Shot 2020-10-22 at 10 59 56 AM

Moving the quotation marks outside the link
Screen Shot 2020-10-22 at 11 01 10 AM

Generates this output:
Screen Shot 2020-10-22 at 11 01 55 AM

I thought that maybe the link style was an issue, so I updated that too:
Screen Shot 2020-10-22 at 11 03 23 AM

But that generates the same output
Screen Shot 2020-10-22 at 11 03 53 AM

Lastly I thought maybe it was the italic:
Screen Shot 2020-10-22 at 11 04 45 AM

But removing it generates the same spacing issues as before.
Screen Shot 2020-10-22 at 11 05 26 AM

Probably this has to do with the styling somewhere, and I expect this issue is the underlying cause of these bugs issues:

@nate-double-u
Copy link
Contributor Author

There is a solution to this issue here: cncf/hugo-netlify-starter#93

@chalin
Copy link

chalin commented Jul 26, 2021

FYI, you'll probably want to wait for cncf/hugo-netlify-starter#77 to be fixed before adopting the render-link hook used in the starter.

@chalin
Copy link

chalin commented Jul 27, 2021

FYI, you'll probably want to wait for cncf/hugo-netlify-starter#77 to be fixed before adopting the render-link hook used in the starter.

The fix has landed.

@nabokihms
Copy link
Member

We migrated to Docsy. There is probably no issue anymore. At least all previously found bugs are now fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants