This repository has been archived by the owner on Jun 14, 2024. It is now read-only.
fix white space around links #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kapunahelewong
force-pushed
the
render-link-fix
branch
from
09524ca to
bd84336
Compare
kapunahelewong
force-pushed
the
render-link-fix
branch
2 times, most recently
from
2d4226e to
eaa3b3f
Compare
chalin
suggested changes
Jul 26, 2021
kapunahelewong
force-pushed
the
render-link-fix
branch
from
eaa3b3f to
803c98c
Compare
|
Oooh that worked perfectly. Thank you @chalin!! |
nate-double-u
previously approved these changes
Jul 26, 2021
Fixes cncf#45 Signed-off-by: Kapunahele Wong <kapunahelewong@gmail.com>
kapunahelewong
dismissed stale reviews from nate-double-u and chalin
via
031b447
kapunahelewong
force-pushed
the
render-link-fix
branch
from
803c98c to
031b447
Compare
chalin
approved these changes
Jul 26, 2021
I had the same thing over on #86, the GitHub UI said the branch was out of date with |
|
Anything left to do here before this is merged @kapunahelewong? If not, please do the following:
|
|
Oops, @nate-double-u, beat you to it. Well, for next time then :). |
|
(sorry, I merged it literally the same moment you posted that. I did link the issue before I did so 😅) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a work in progress trying to fix the extra space that appears around links: