serviceconfig: Return errors instead of skipping invalid retry policy…

… config
dfawley · Dec 5, 2024 · 2574a1a · 2574a1a
1 parent 645aadf
commit 2574a1a
Show file tree

Hide file tree

Showing 2 changed files with 169 additions and 53 deletions.
diff --git a/service_config.go b/service_config.go
@@ -278,8 +278,7 @@ func convertRetryPolicy(jrp *jsonRetryPolicy, maxAttempts int) (p *internalservi
 		jrp.MaxBackoff <= 0 ||
 		jrp.BackoffMultiplier <= 0 ||
 		len(jrp.RetryableStatusCodes) == 0 {
-		logger.Warningf("grpc: ignoring retry policy %v due to illegal configuration", jrp)
-		return nil, nil
+		return nil, fmt.Errorf("invalid retry policy (%v): ", jrp)
 	}
 
 	if jrp.MaxAttempts < maxAttempts {