Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scrape worker nodes logs #1495

Merged
merged 5 commits into from
Aug 2, 2024
Merged

Conversation

samidbb
Copy link
Contributor

@samidbb samidbb commented Aug 1, 2024

Describe your changes

Scrape logs from k8s worker nodes including journal logs
journal logs require updating grafana helm chart to the latest (1.4.4)

Issue ticket number and link

https://github.com/dfds/cloudplatform/issues/2716

Checklist before requesting a review

Is it a new release?

  • Apply a release tag release:(major|minor|patch), following semantic versioning in this guide or norelease if there is no changes to the Terraform code

@samidbb samidbb self-assigned this Aug 1, 2024
rifisdfds
rifisdfds previously approved these changes Aug 1, 2024
Copy link
Contributor

@rifisdfds rifisdfds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only suggestions would have been to make the exclusions a variable and look to making it easy to toggle on and off, but we can do that at a later date if ever required

@samidbb samidbb added the release:minor Triggers a minor release label Aug 1, 2024
@samidbb samidbb marked this pull request as ready for review August 1, 2024 13:14
@samidbb samidbb requested a review from a team as a code owner August 1, 2024 13:14
rifisdfds
rifisdfds previously approved these changes Aug 2, 2024
@samidbb samidbb merged commit 560b551 into master Aug 2, 2024
14 checks passed
@samidbb samidbb deleted the feature/ship-worker-nodes-logs-to-grafana branch August 2, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:minor Triggers a minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants