Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sub module to manage sharing through AWS Resource Manager and use it to share IPAM pools #1539

Merged
merged 2 commits into from
Sep 12, 2024

Conversation

avnes
Copy link
Contributor

@avnes avnes commented Sep 11, 2024

Describe your changes

Add sub module to manage sharing through AWS Resource Manager and use it to share IPAM pools

Issue ticket number and link

https://github.com/dfds/cloudplatform/issues/2993

Checklist before requesting a review

  • I have tested changes in my sandbox
  • I have rebased the code to master (or merged in the latest from master)

Is it a new release?

  • Apply a release tag release:(major|minor|patch), following semantic versioning in this guide or norelease if there is no changes to the Terraform code

@avnes avnes requested a review from a team as a code owner September 11, 2024 14:38
@avnes avnes added the release:minor Triggers a minor release label Sep 11, 2024
Copy link
Contributor

@silviucalin silviucalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sure you've tested this and would really like a bit a chat about this tomorrow in the office :-)

@avnes avnes merged commit ba2a8c2 into master Sep 12, 2024
5 of 6 checks passed
@avnes avnes deleted the feature/cloudplatform/2993 branch September 12, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:minor Triggers a minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants