Generalized the conditional rbm. #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than assuming the conditioned patterns will be the visible units at previous time steps, we just take a size to condition on and provide a constructor that takes the number of steps as a feature. With the above change the split_vis method has changed and all references to `history` or `hist` have been changed to `cond`. Also, fixed an issue on line 51 which was passing `Bernoulli` instead of V and H parametrics to the more general constructor.
Closed
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than assuming the conditioned patterns will be the visible
units at previous time steps, we just take a size to condition on and
provide a constructor that takes the number of steps as a feature.
With the above change the
split_vismethod has changed and all referencesto
historyorhisthave been changed tocond.Also, fixed an issue on line 51 which was passing
Bernoulliinstead of V andH parametrics to the more general constructor.