Fixed sparsity calculation for conditional rbm and several precision … #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…issues. 1. In the sparsity calculation for conditional rbms `hid_means` takes just the visible input provided by `split_vis(rbm, X)`. 2. The `gemm!` calls in gradient_classic for the conditional weights weren't using the appropriate precision (ie: Float32 w/ sparsity) 3. The `free_energy` function will often produces NaNs do to `log(0)` or lack of precision.
|
Cool, thanks for fixes. |
dfdx
added a commit
that referenced
this pull request
Mar 5, 2016
Fixed sparsity calculation for conditional rbm and several precision …
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…issues.
hid_meanstakesjust the visible input provided by
split_vis(rbm, X).gemm!calls in gradient_classic for the conditional weightsweren't using the appropriate precision (ie: Float32 w/ sparsity)
free_energyfunction will often produces NaNs do tolog(0)or lack of precision.