Add trusted types support #32
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes the Karma jasmine html reporter compatible with an enforced Trusted Types policy. This should only be necessary for a limited time, as the next version of the proposed specification will not require any special code for URLS (except javascript: URLS). More info about the proposed Trusted Types standard at https://github.com/WICG/trusted-types
|
Related: karma-runner/karma#3360 |
|
See: https://github.com/dfederm/karma-jasmine-html-reporter/blob/master/README.md#develop Basically, make the change to Jasmine and then I'll copy it into this package |
|
Sent over jasmine/jasmine#1750 |
|
What is the status of this change ? |
|
On revisiting, I don't think this is necessary anymore, as the shipping version of TrustedTypes doesn't have or need the createURL function. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the Karma jasmine html reporter compatible with an enforced Trusted Types policy.
This should only be necessary for a limited time, as the next version of the proposed specification will not require any special code for URLS (except javascript: URLS).
More info about the proposed Trusted Types standard at https://github.com/WICG/trusted-types