Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Divide by zero #3

Merged
merged 5 commits into from
Feb 8, 2021
Merged

Divide by zero #3

merged 5 commits into from
Feb 8, 2021

Conversation

dfelton
Copy link
Owner

@dfelton dfelton commented Feb 8, 2021

Backwards Incompatible Changes:

  • Strict types enforced globally
  • Throw exception on attempt to divide by zero

@dfelton
throw exception when attempting to divide by zero
19cf790 
was causing TypeError since bcdiv would yield null and we'd attempt to return null instead of a string.
@dfelton
strict types
f130414
@dfelton
remove lock file. this is a library not a project
27cb0c4
@dfelton
Ignore composer lock file for library package type
86de744
@dfelton
v2.0.0
4fc6767 
Backwards Incompatible Changes:

- Strict types enforced globally
- Throw exception on attempt to divide by zero
@dfelton dfelton merged commit f64f46c into master Feb 8, 2021
@dfelton
Copy link
Owner Author

dfelton commented Feb 8, 2021

Partially addresses issue #1

@dfelton dfelton deleted the divide-by-zero branch February 8, 2021 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dfelton