feat: introduces X-Request-ID header to more easily identify retried requests #678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
Co-authored-by: Eric Swanson <64809312+ericswanson-dfinity@users.noreply.github.com>
…to SDK-880-header-nonce
ghost
approved these changes
Jan 20, 2023
| }, | ||
| body: cbor.encode(expectedRequest), | ||
| }); | ||
| const call1 = calls[0][0]; |
There was a problem hiding this comment.
Suggested change
| const call1 = calls[0][0]; | |
| const [call1, call2] = calls[0] |
| @@ -293,10 +293,10 @@ export class HttpAgent implements Agent { | |||
| request: { | |||
| body: null, | |||
| method: 'POST', | |||
| headers: { | |||
| headers: new Headers({ | |||
| 'Content-Type': 'application/cbor', | |||
| ...(this._credentials ? { Authorization: 'Basic ' + btoa(this._credentials) } : {}), | |||
There was a problem hiding this comment.
btoa is deprecated in node. would this ever run in a node context? if it were, better to detect the environment and use Buffer instead
if (isBrowserEnv()) {
window.btoa(this._credentials);
}
if (isNodeEnv()) {
Buffer.from(this._credentials).toString('base64')
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
During the SNS-1 launch retrospective, we identified the difficulty in identifying retried requests as a pain point.
Adding a unique request id header (using the standard key, despite the similarity to the Request ID specified for checking the status of updates in the Internet Computer Specification
Fixes # SDK-880
How Has This Been Tested?
new unit tests
Checklist: