feat: allow for setting HttpAgent ingress expiry using ingressExpiryInMinutes
option
#905
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Simply adds a configurable ingress expiry option. Includes checks against <= 0 and > 5 minutes, new errors, and e2e tests about behavior.
Important question to resolve: when the expiry is less than or equal to one minute, the tests often fail in practice due to the current "round down to the nearest minute". How should the agent handle this?
My suggestion would be either
ingressExpiryInMinutes
is passedingressExpiryInMinutes
is passed and the value is less than 2 minutesHow Has This Been Tested?
new e2e tests and unit tests
Checklist: