-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: v3 api sync call #906
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
…into kai/SDK-1448-sync-call
ericswanson-dfinity
requested changes
Aug 13, 2024
ericswanson-dfinity
approved these changes
Aug 13, 2024
venkkatesh-sekar
approved these changes
Aug 27, 2024
AlexV525
added a commit
to AstroxNetwork/agent_dart
that referenced
this pull request
Oct 15, 2024
AlexV525
added a commit
to AstroxNetwork/agent_dart
that referenced
this pull request
Oct 15, 2024
AlexV525
added a commit
to AstroxNetwork/agent_dart
that referenced
this pull request
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements
sync_call
functionality from the v3 api for improved performance. See dfinity/interface-spec#265 for more detailsChanges:
HttpAgent.call
, which defaults totrue
Fixes SDK-1448
How Has This Been Tested?
Updates to unit tests and e2e tests run against dfx
0.22.0
and0.23.0
to ensure backwards compatibilityChecklist: