Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: updating dependencies for elliptic advisory #912

Merged
merged 8 commits into from
Aug 5, 2024
Merged

Conversation

krpeacock
Copy link
Contributor

@krpeacock krpeacock commented Aug 5, 2024

Description

  • feat: replaces hdkey and bip32 implementations with @scure/bip39 and @scure/bip32 due to vulnerability and lack of maintenance for elliptic
  • chore: bumps dev dependency versions to remove warnings
  • chore: addresses eslint errors uncovered by bumping eslint version

Checklist:

  • My changes follow the guidelines in CONTRIBUTING.md.
  • The title of this PR complies with Conventional Commits.
  • I have edited the CHANGELOG accordingly.
  • I have made corresponding changes to the documentation.

@krpeacock krpeacock requested a review from a team as a code owner August 5, 2024 18:14
Copy link
Contributor

github-actions bot commented Aug 5, 2024

size-limit report 📦

Path Size
@dfinity/agent 85.56 KB (-0.51% 🔽)
@dfinity/candid 13.58 KB (0%)
@dfinity/principal 4.97 KB (0%)
@dfinity/auth-client 60.3 KB (-0.9% 🔽)
@dfinity/assets 80.72 KB (+0.09% 🔺)
@dfinity/identity 57.51 KB (-0.91% 🔽)
@dfinity/identity-secp256k1 130.53 KB (-51.04% 🔽)

@ericswanson-dfinity ericswanson-dfinity dismissed their stale review August 5, 2024 18:28

CI failures did not show up

@krpeacock krpeacock merged commit 3b4df1b into main Aug 5, 2024
28 checks passed
@krpeacock krpeacock deleted the kai/npm-audit branch August 5, 2024 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants