Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: JsDoc typo in DelegationIdentity class's fromDelegation method #951

Merged
merged 3 commits into from
Dec 12, 2024
Merged

fix: JsDoc typo in DelegationIdentity class's fromDelegation method #951

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fbd131c
fix: JsDoc typo in DelegationIdentity class's `fromDelegation` method
georgiod9 Nov 4, 2024
c962a3d
chore: formatting and changelog
krpeacock Dec 12, 2024
9f91059
Merge branch 'main' into fix/delegation-typo
krpeacock Dec 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions docs/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@

### Changed

- chore: Removes warning that users found unhelpful, when a message originates from other sources than the identity provider in `AuthClient` during authentication.
- chore: fixes typo in DelegationIdentity jsdoc comment
- chore: Removes warning that users found unhelpful, when a message originates from other sources than the identity provider in `AuthClient` during authentication.
- fix: Make pollForResponse typesafe to avoid exceptions from unknown requests

Expand Down
2 changes: 1 addition & 1 deletion packages/identity/src/identity/delegation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,7 +266,7 @@ export class DelegationChain {
export class DelegationIdentity extends SignIdentity {
/**
* Create a delegation without having access to delegateKey.
* @param key The key used to sign the reqyests.
* @param key The key used to sign the requests.
* @param delegation A delegation object created using `createDelegation`.
*/
public static fromDelegation(
Expand Down
Loading