Skip to content

Conversation

@ninegua
Copy link
Member

@ninegua ninegua commented Oct 15, 2021

This enables automatic build of release binaries when main branch is updated. Each release is tagged with the first 7 letters of the commit hash. Linux binaries are linked statically.

Note that this has nothing to do with making versioned source releases. It is only meant to be an automated build to provide the latest (and historical) binaries.

@ninegua ninegua requested a review from a user October 15, 2021 20:57
runs-on: ${{ matrix.os }}
strategy:
fail-fast: false
matrix:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we be specifying the rust toolchain version here? (1.52.1 at the moment for this repo)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately static build via musl is only using 1.50.0. It is not a problem now, but we can find alternatives later if it breaks.

@ghost ghost merged commit 20162d2 into dfinity:main Oct 15, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant