candid asts as candid data #161
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewhammer
commented
Jan 12, 2021
| @@ -1,22 +1,33 @@ | |||
| use crate::types::Label; | |||
| use crate::Result; | |||
| use pretty::RcDoc; | |||
| use crate::{CandidType, Deserialize}; | |||
There was a problem hiding this comment.
@chenyan-dfinity I tried to use CandidType below each place where I added Deserialize, but I got some macro errors. I think the issue is about the macro being used from the crate that defines it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IDLTypeand related types)Back story
Note that this is asking for candid asts in Rust to be usable as candid data, not as a plaintext string. Plaintext forms for candid types are supported in Rust, but not in every language (not in Motoko). By converting these ASTs, as data, into candid binary form, we can send them to canisters that act on them as ASTs (as data, not as strings) and get these ASTs back without re-doing the pretty printer for candid types.