Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set default config for different targets #470

Merged
merged 4 commits into from
Oct 4, 2023
Merged

Conversation

chenyan-dfinity
Copy link
Contributor

  • For wasm target, full_error_message = false, which only outputs concrete type in the error message when the type is small. For non-wasm target, it's set to true.
  • For wasm target, set zero_sized_values to 0. Otherwise, it's 2M, which conforms to the spec.

@github-actions
Copy link

github-actions bot commented Oct 4, 2023

Benchmark for a57c4d1

Click to view benchmark
Test Base PR %
Blob/&str 203.0±65.22µs 197.3±65.79µs -2.81%
Blob/ByteBuf 140.7±51.79µs 137.9±50.99µs -1.99%
Blob/Bytes 111.5±46.60µs 108.3±48.15µs -2.87%
Blob/String 258.8±134.98µs 253.8±134.18µs -1.93%
Collections/vec (text, nat) 64.5±0.87ms 63.5±0.58ms -1.55%
Collections/vec int 30.2±0.08ms 30.4±0.10ms +0.66%
Collections/vec int64 18.1±0.28ms 18.6±0.17ms +2.76%
Collections/vec nat8 13.7±0.77ms 13.9±0.05ms +1.46%
option list/1024 1345.8±4.74µs 1336.1±5.31µs -0.72%
profiles/1024 2.7±0.03ms 2.6±0.00ms -3.70%
variant list/1024 1118.8±2.14µs 1120.5±16.39µs +0.15%

@github-actions
Copy link

github-actions bot commented Oct 4, 2023

Benchmark for d608a6b

Click to view benchmark
Test Base PR %
Blob/&str 197.5±67.24µs 193.8±67.76µs -1.87%
Blob/ByteBuf 141.2±51.39µs 142.8±50.54µs +1.13%
Blob/Bytes 101.0±36.55µs 100.5±35.70µs -0.50%
Blob/String 217.3±77.33µs 216.4±75.15µs -0.41%
Collections/vec (text, nat) 64.3±1.01ms 62.5±0.82ms -2.80%
Collections/vec int 30.2±0.22ms 30.3±0.08ms +0.33%
Collections/vec int64 17.1±0.26ms 17.8±0.21ms +4.09%
Collections/vec nat8 13.2±0.08ms 13.3±0.06ms +0.76%
option list/1024 1345.4±2.01µs 1332.5±2.58µs -0.96%
profiles/1024 2.8±0.01ms 2.6±0.00ms -7.14%
variant list/1024 1120.5±4.02µs 1119.9±3.79µs -0.05%

@chenyan-dfinity chenyan-dfinity merged commit a8322be into master Oct 4, 2023
3 checks passed
@chenyan-dfinity chenyan-dfinity deleted the fix-error branch October 4, 2023 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants