Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ci): Correctly pass secrets to the k8s-deployments composite actions #120

Merged
merged 1 commit into from
Jan 26, 2024
Merged

fix(ci): Correctly pass secrets to the k8s-deployments composite actions #120

merged 1 commit into from
Jan 26, 2024

Conversation

sasa-tomic
Copy link
Member

@sasa-tomic sasa-tomic commented Jan 26, 2024 •
edited
Loading

Composite actions do not have access to secrets, by default. Secrets need to be explicitly passed to them.

@sasa-tomic sasa-tomic requested a review from a team as a code owner January 26, 2024 14:23
NikolaMilosa
NikolaMilosa approved these changes Jan 26, 2024
View reviewed changes
Copy link
Contributor

@NikolaMilosa NikolaMilosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes

@sasa-tomic sasa-tomic added this pull request to the merge queue Jan 26, 2024
Merged via the queue into main with commit 41f0ce3 Jan 26, 2024
3 checks passed
@sasa-tomic sasa-tomic deleted the container-fix-pushing branch January 26, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NikolaMilosa NikolaMilosa NikolaMilosa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sasa-tomic @NikolaMilosa