Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve XDR explanation #88

Merged
merged 3 commits into from
Jan 23, 2024
Merged

Improve XDR explanation #88

merged 3 commits into from
Jan 23, 2024

Conversation

yvonneanne
Copy link
Contributor

No description provided.

@yvonneanne yvonneanne requested a review from a team as a code owner January 22, 2024 12:11
Copy link
Contributor

@nikola-milosa nikola-milosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but I would ask @sasa-tomic for another set of eyes

Copy link
Member

@sasa-tomic sasa-tomic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @yvonneanne !

@sasa-tomic sasa-tomic enabled auto-merge (squash) January 22, 2024 14:18
auto-merge was automatically disabled January 23, 2024 10:36

Merge queue setting changed

@sasa-tomic sasa-tomic enabled auto-merge January 23, 2024 11:09
@sasa-tomic sasa-tomic added this pull request to the merge queue Jan 23, 2024
Merged via the queue into dfinity:main with commit a301ae3 Jan 23, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants