Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(nns/sns): Minor fix for release script #3764

Merged
merged 1 commit into from
Feb 4, 2025
Merged

fix(nns/sns): Minor fix for release script #3764

merged 1 commit into from
Feb 4, 2025

Conversation

jasonz-dfinity
Copy link
Contributor

Minor fixes:

  1. When asking the user for whether they'd like to submit proposals, yes/no options are reversed
  2. The comment for asking for neuron ids was misplaced

@jasonz-dfinity jasonz-dfinity requested a review from a team as a code owner February 4, 2025 22:21
github-actions[bot]
github-actions bot previously requested changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this pull request affects the behavior of any canister owned by
the Governance team, remember to update the corresponding
unreleased_changes.md file(s).

To acknowldge this reminder (and unblock the PR), dismiss this
code review by going to the bottom of the pull request page, and
supply one of the following reasons:

  1. Done.

  2. No canister behavior changes.

@anchpop anchpop dismissed github-actions[bot]’s stale review February 4, 2025 22:23

No canister behavior changes.

@anchpop anchpop enabled auto-merge February 4, 2025 22:23
@anchpop anchpop changed the title release(nns/sns): Minor fix for release script fix(nns/sns): Minor fix for release script Feb 4, 2025
@github-actions github-actions bot added the fix label Feb 4, 2025
@anchpop anchpop added this pull request to the merge queue Feb 4, 2025
Merged via the queue into master with commit f9a5f41 Feb 4, 2025
27 of 28 checks passed
@anchpop anchpop deleted the jason/misc-release-runscript branch February 4, 2025 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anchpop anchpop anchpop approved these changes

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees
No one assigned
Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jasonz-dfinity @anchpop