Skip to content

refactor: switch from agent-rs to miracl_core #590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 12, 2022
Merged

refactor: switch from agent-rs to miracl_core #590

merged 2 commits into from
Jul 12, 2022

Conversation

@Daniel-Bloom-dfinity
Copy link
Contributor

@Daniel-Bloom-dfinity Daniel-Bloom-dfinity commented Jul 7, 2022

Description

Companion to dfinity/miracl_core_bls12381#6

How Has This Been Tested?

Passes npm run test

Checklist:

  • My changes follow the guidelines in CONTRIBUTING.md.
  • The title of this PR complies with Conventional Commits.
  • N/A I have edited the CHANGELOG accordingly.
  • N/A I have made corresponding changes to the documentation.

@Daniel-Bloom-dfinity Daniel-Bloom-dfinity requested a review from a team as a code owner July 7, 2022 05:40
@Daniel-Bloom-dfinity Daniel-Bloom-dfinity mentioned this pull request Jul 7, 2022
Merged
chenyan-dfinity
chenyan-dfinity approved these changes Jul 7, 2022
View reviewed changes
Copy link
Contributor

@chenyan-dfinity chenyan-dfinity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@krpeacock krpeacock merged commit 97f9352 into main Jul 12, 2022
@krpeacock krpeacock deleted the dbloom/miracle_core branch July 12, 2022 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@krpeacock krpeacock krpeacock approved these changes

@chenyan-dfinity chenyan-dfinity chenyan-dfinity approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Daniel-Bloom-dfinity @krpeacock @chenyan-dfinity