Handle all well-known domains in canister id resolution #2392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the canister id resolution function more versatile to also take advantage of the canister id subdomain for other well-known domains (apart from `localhost`).
lmuntaner
approved these changes
Mar 29, 2024
| const wellKnownDomains = [ | ||
| "ic0.app", | ||
| "icp0.io", | ||
| "icp0.io", |
There was a problem hiding this comment.
Why is this duplicated?
There was a problem hiding this comment.
To make the test fail in case somebody accidentally changes the list in the production code. If somebody intentionally changes the list, they will most likely also look to change the test.
There was a problem hiding this comment.
Sorry, I don't understand it. What does it help to have it twice?
There was a problem hiding this comment.
Ah, sorry. I thought you meant why have the list separately in the production and test code. I did not realized I actually duplicated a value in the list here. Fixed in #2397.
frederikrothenberger
added a commit
that referenced
this pull request
Apr 2, 2024
This fixes an error introduced in #2392 that duplicates a domain in a test for canister id resolution.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 2, 2024
This fixes an error introduced in #2392 that duplicates a domain in a test for canister id resolution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the canister id resolution function more versatile to also take advantage of the canister id subdomain for other well-known domains (apart from
localhost).🟡 Some screens were changed