-
Notifications
You must be signed in to change notification settings - Fork 9
feat: enable memory64 for wasi testing
#300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe update modifies the test command implementation to include the Changes
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
npm error Exit handler never called! 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🔇 Additional comments (1)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
Thank you Released in 1.10.0 |
dfinity/mops#300 is merged and released. dfinity/motoko-core#344 adopted it. _Note_: I wouldn't have problems to leave this new step in this workflow, but separating it out into a second one should also be doable with a little bit of duplication. We can iterate from this point. _Note_: Without the `mops` 64-bit fix the tests failed, so the rainy-day path is well-tested!
Poor-man's version of #299, but this should work for now.
Motivation: Starting with version > 0.14.4 of
mocthe 64-bit mode is the default, somopstests should allow it.https://github.com/bytecodealliance/wasmtime/blob/release-14.0.0/RELEASES.md#1400 is the minimum and supports
memory64, so we are safe.