Skip to content

Conversation

@ggreif
Copy link
Contributor

@ggreif ggreif commented Jul 8, 2025

Poor-man's version of #299, but this should work for now.

Motivation: Starting with version > 0.14.4 of moc the 64-bit mode is the default, so mops tests should allow it.

https://github.com/bytecodealliance/wasmtime/blob/release-14.0.0/RELEASES.md#1400 is the minimum and supports memory64, so we are safe.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jul 8, 2025

Walkthrough

The update modifies the test command implementation to include the -W memory64 flag when spawning the wasmtime process for running WebAssembly tests in WASI mode, but only if the detected wasmtime version is at least 14.0.0. No other functionality or exported declarations are changed.

Changes

File(s) Change Summary
cli/commands/test/test.ts Adds -W memory64 flag to wasmtime command for version ≥ 14.0.0.

Poem

A flag for memory, sixty-four bits,
Now joins our wasmtime command line kits.
Only for versions, fourteen and above,
The test command gets a gentle shove.
With careful checks and thoughtful care,
Our WebAssembly tests hop everywhere! 🐇

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

npm error Exit handler never called!
npm error This is an error with npm itself. Please report this error at:
npm error https://github.com/npm/cli/issues
npm error A complete log of this run can be found in: /.npm/_logs/2025-07-08T17_16_11_487Z-debug-0.log


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c0b2330 and 68a4cc4.

📒 Files selected for processing (1)
  • cli/commands/test/test.ts (2 hunks)
🔇 Additional comments (1)
cli/commands/test/test.ts (1)

292-292: LGTM! Memory64 flag addition is correct.

The addition of -W memory64 follows the established pattern for other warning flags and is properly gated by the wasmtime version check (>=14.0.0). This enables memory64 support for WASI testing as intended.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@ZenVoich ZenVoich merged commit 676c2ec into dfinity:main Jul 8, 2025
17 of 18 checks passed
@ZenVoich
Copy link
Contributor

ZenVoich commented Jul 8, 2025

Thank you

Released in 1.10.0

mergify bot pushed a commit to dfinity/motoko that referenced this pull request Jul 10, 2025
dfinity/mops#300 is merged and released. dfinity/motoko-core#344 adopted it.

_Note_: I wouldn't have problems to leave this new step in this workflow, but separating it out into a second one should also be doable with a little bit of duplication. We can iterate from this point.

_Note_: Without the `mops` 64-bit fix the tests failed, so the rainy-day path is well-tested!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants