feat: implement ExperimentalInternetComputer.countInstructions(comp)
#381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/ExperimentalInternetComputer.mo
Outdated
| /// NB: Currently, the only available counter is `0`, | ||
| /// measuring executed wasm instructions. | ||
| /// (see [Performance Counter](https://internetcomputer.org/docs/current/references/ic-interface-spec#system-api-performance-counter)) | ||
| public func measureCounter(counter : Nat32) : (comp : () -> ()) -> Nat64 { |
There was a problem hiding this comment.
I think we can hardcode 0 here, and change the name to measureCycleCounter? If we ever get another counter type, we probably want to give it a more meaningful name anyway, instead of relying on a number type.
There was a problem hiding this comment.
It it even cycles though? I think it's just instructions.
There was a problem hiding this comment.
chenyan-dfinity
approved these changes
Jun 6, 2022
crusso
changed the title
ExperimentalInternetComputer.measureCounter(counter)(comp)ExperimentalInternetComputer.countInstructions(comp)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement basic
ExperimentalInternetComputer.countInstructions(comp), hiding the limitations of IC performance counters (reset to 0 after each entrypoint, invariant within blocks) by restricting measurements to local, synchronous computations.cf. dfinity/motoko#3294