Implicit pattern across entire core package
#398
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No description provided. |
crusso
reviewed
Sep 29, 2025
crusso
reviewed
Sep 29, 2025
christoph-dfinity
requested changes
Sep 29, 2025
Contributor
christoph-dfinity
left a comment
christoph-dfinity
left a comment
There was a problem hiding this comment.
I added comments to the two patterns that need changing I spotted. Thanks for doing this!
crusso
reviewed
Sep 29, 2025
crusso
reviewed
Sep 29, 2025
crusso
reviewed
Sep 29, 2025
crusso
reviewed
Sep 29, 2025
crusso
reviewed
Sep 29, 2025
crusso
reviewed
Sep 29, 2025
crusso
reviewed
Sep 29, 2025
rvanasa
commented
Sep 29, 2025
rvanasa
commented
Sep 29, 2025
crusso
reviewed
Sep 29, 2025
rvanasa
commented
Sep 29, 2025
crusso
reviewed
Sep 29, 2025
rvanasa
commented
Sep 29, 2025
crusso
reviewed
Sep 29, 2025
rvanasa
commented
Sep 29, 2025
rvanasa
commented
Sep 29, 2025
rvanasa
commented
Sep 29, 2025
rvanasa
commented
Sep 29, 2025
Co-authored-by: Christoph <christoph.hegemann@dfinity.org> Co-authored-by: Claudio Russo <claudio@dfinity.org>
crusso
reviewed
Sep 29, 2025
crusso
reviewed
Sep 29, 2025
crusso
reviewed
Sep 29, 2025
crusso
reviewed
Sep 29, 2025
crusso
reviewed
Sep 29, 2025
crusso
reviewed
Sep 29, 2025
crusso
reviewed
Sep 29, 2025
crusso
reviewed
Sep 29, 2025
crusso
reviewed
Sep 29, 2025
Co-authored-by: Claudio Russo <claudio@dfinity.org>
crusso
reviewed
Sep 29, 2025
crusso
reviewed
Sep 29, 2025
Co-authored-by: Claudio Russo <claudio@dfinity.org>
Collaborator
Author
|
@christoph-dfinity, feel free to merge into #397. Claudio and I looked this over, and it should cover all of the |
christoph-dfinity
approved these changes
Sep 29, 2025
Contributor
christoph-dfinity
left a comment
christoph-dfinity
left a comment
There was a problem hiding this comment.
LGTM! Thank you for doing this
P4P5T123
pushed a commit
that referenced
this pull request
Oct 9, 2025
* First pass * Another pass * Fix stragglers * Fix more stragglers * Apply suggestions from code review Co-authored-by: Christoph <christoph.hegemann@dfinity.org> Co-authored-by: Claudio Russo <claudio@dfinity.org> * Apply suggestions from code review Co-authored-by: Claudio Russo <claudio@dfinity.org> * Various fixes * Apply suggestions from code review Co-authored-by: Claudio Russo <claudio@dfinity.org> * Fix * Update API lockfile --------- Co-authored-by: Christoph <christoph.hegemann@dfinity.org> Co-authored-by: Claudio Russo <claudio@dfinity.org>
christoph-dfinity
added a commit
that referenced
this pull request
Oct 13, 2025
* chore: updates matchers package to mops release (#394) * makes comparison arguments to Map functions implicit * use implicits in tests for Map * make comparison arguments to Set functions implicit * update Set tests to use implicits * remove local bindings, now that we can disambiguate Nat and Int * make equal arguments implicit * rename internal Map and Set size to size_ to avoid clash with contextual dot * Implicit pattern across entire `core` package (#398) * First pass * Another pass * Fix stragglers * Fix more stragglers * Apply suggestions from code review Co-authored-by: Christoph <christoph.hegemann@dfinity.org> Co-authored-by: Claudio Russo <claudio@dfinity.org> * Apply suggestions from code review Co-authored-by: Claudio Russo <claudio@dfinity.org> * Various fixes * Apply suggestions from code review Co-authored-by: Claudio Russo <claudio@dfinity.org> * Fix * Update API lockfile --------- Co-authored-by: Christoph <christoph.hegemann@dfinity.org> Co-authored-by: Claudio Russo <claudio@dfinity.org> * rename .size on Queue * add TODO comment * I was using a stale compiler * updates the toolchain to a pre-release * updated mops to pull down draft branch and adjust tests (#399) * feat: Add PriorityQueue (#392) * Partial implementation. * Fix bug and add peek. * Started with tests, and more functions. * Towards more tests, adding SetPriorityQueue. * Completing first implementation, with tests. * Add comments to PriorityQueue.mo * Move set implementation and add benchmark. * Better holes. * Extra benchmark. * More tests. * . * Comments. * Optimization. * Comments for SetWrapper. * Move SetWrapper. * Run format. * . * npm run validate * Fix imports in docstrings. * Add Changelog entry. * Fix Changelog entry. * Remove inefficient push and pop operations (and benchmarks for them). * Move PriorityQueueSet.mo * Fix validation. * Update Changelog. * Update implicits for RealTimeQueue * Update implicits for PriorityQueue * Update API lockfile --------- Co-authored-by: Ryan Vandersmith <ryan.vandersmith@dfinity.org> Co-authored-by: Claudio Russo <claudio@dfinity.org> Co-authored-by: Andrei Constantinescu <andrei.constantinescu@dfinity.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expands on #397.