Skip to content

feat: Add isCleanReject to the Error module, align reject code order with spec and improve comments #401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Oct 2, 2025
Merged

feat: Add isCleanReject to the Error module, align reject code order with spec and improve comments #401

merged 7 commits into from
Oct 2, 2025

Conversation

@Andrei1998
Copy link
Contributor

@Andrei1998 Andrei1998 commented Oct 2, 2025 •
edited
Loading

Add isCleanReject(error : Error) : Bool as proposed in #400.

Side changes:

  • Update the order of ErrorCode variants corresponding to reject codes to match the IC interface specification.
  • Improve comments for #canister_error and #system_unknown.

@Andrei1998 Andrei1998 changed the title feat: Add isCleanReject to the Error module (and align reject code order with spec) feat: Add isCleanReject to the Error module and align reject code order with spec Oct 2, 2025
@Andrei1998 Andrei1998 marked this pull request as ready for review October 2, 2025 15:19
@Andrei1998 Andrei1998 requested a review from a team as a code owner October 2, 2025 15:19
@Andrei1998 Andrei1998 changed the title feat: Add isCleanReject to the Error module and align reject code order with spec feat: Add isCleanReject to the Error module (+ align reject code order with spec and improve comments) Oct 2, 2025
@Andrei1998 Andrei1998 changed the title feat: Add isCleanReject to the Error module (+ align reject code order with spec and improve comments) feat: Add isCleanReject to the Error module, align reject code order with spec and improve comments Oct 2, 2025
@Andrei1998
Copy link
Contributor Author

Andrei1998 commented Oct 2, 2025

I couldn't think of a good snippet to put in the docstring, hence suggestions are welcome.
My take would be to add it to the snippet in the docstring of isRetryPossible below, and I am thinking to do this in a follow-up PR where I revamp the docstring for isRetryPossible (part of the other proposal in #400).

rvanasa
rvanasa approved these changes Oct 2, 2025
View reviewed changes
Copy link
Collaborator

@rvanasa rvanasa left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; thanks!

@rvanasa rvanasa merged commit e47c123 into dfinity:main Oct 2, 2025
13 of 15 checks passed
@Andrei1998 Andrei1998 mentioned this pull request Oct 3, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rvanasa rvanasa rvanasa approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Andrei1998 @rvanasa