Skip to content

Conversation

@AStepanov25
Copy link
Contributor

No description provided.

@AStepanov25 AStepanov25 requested a review from a team as a code owner October 19, 2025 14:33
rvanasa
rvanasa previously approved these changes Oct 24, 2025
Copy link
Collaborator

@rvanasa rvanasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions github-actions bot dismissed rvanasa’s stale review November 5, 2025 13:17

Review dismissed by automation script.

@timohanke
Copy link
Contributor

This function can need a variant that operates on a range instead of on the whole list. If we add such a variant then do we still need this version that operates on the whole list? Or is only the one that operates on a range enough?

@AStepanov25
Copy link
Contributor Author

A variant that operates on a range is too specific, the user can use forEachRange in this case.

@timohanke
Copy link
Contributor

Ok. LGTM then.

@rvanasa rvanasa merged commit 3047c4b into dfinity:main Nov 12, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants