Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

todo: restore GC in heartbeat once IC heartbeats support DTS #3622

Closed
crusso opened this issue Dec 6, 2022 · 1 comment
Closed

todo: restore GC in heartbeat once IC heartbeats support DTS #3622

crusso opened this issue Dec 6, 2022 · 1 comment

Comments

@crusso
Copy link
Contributor

crusso commented Dec 6, 2022 •
edited by ggreif
Loading

There are two instances of this problem:

  • heartbeat
  • timer
@crusso crusso mentioned this issue Dec 6, 2022
Merged
@ggreif ggreif changed the title todo: restore GC in heartbeat once IC hearbeats support DTS. todo: restore GC in heartbeat once IC heartbeats support DTS Dec 6, 2022
mergify bot pushed a commit that referenced this issue Dec 6, 2022
@crusso
hotfix: suppress GC in heartbeat (#3623)
68f387a 
Mainnet doesn't yet support DTS for `canister_heartbeat` yet, so a long GC may fail to complete when it would in an ordinary message supporting DTS.

This PR suppresses the GC call, leaving it to the already scheduled async message executing Motoko `system` function `heartbeat`, which will run with DTS enabled, avoiding the issue (and a potential space leak).

#3622 tracks the need to revert this hack once IC heartbeats support DTS.
ggreif added a commit that referenced this issue Dec 14, 2022
@ggreif
don't GC from callback endpoint
98cfb4e 
see #3622 for explanation
@luc-blaeser
Copy link
Contributor

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@crusso @luc-blaeser