Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure cabal2nix is used also at build time #1200

Closed
wants to merge 4 commits into from

Conversation

nomeata
Copy link
Collaborator

@nomeata nomeata commented Feb 13, 2020

see #1189 (comment)

My hope is that by adding cabal2nix to the build products, it will
reliably be available on our nix cache.

see #1189 (comment)

My hope is that by adding `cabal2nix` to the build product, it will
reliably be available on our nix cache.
@nomeata
Copy link
Collaborator Author

nomeata commented Feb 13, 2020

Hmm, it’s still trying to build /nix/store/b0sd8xvaxvbpivf9v574pjs70wlmx1rr-ghc-8.8.1.drv here. And GHC-8.8 doesn’t even show up in the build inputs of https://hydra.dfinity.systems/build/635301#tabs-build-deps. I wonder what is pulling this in.

@nomeata nomeata marked this pull request as ready for review February 13, 2020 21:06
@nomeata nomeata changed the title Make sure cabal2nix is used also at build type Make sure cabal2nix is used also at build time Feb 16, 2020
@nomeata
Copy link
Collaborator Author

nomeata commented Feb 19, 2020

I guess this is subsumed by #1220, as the CI check that checks whether the generated files are up to date will necessarily seed the cache with cabal2nix, right, @basvandijk?

@nomeata nomeata closed this Feb 19, 2020
@nomeata nomeata deleted the joachim/nix/cabal2nix branch April 30, 2021 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant