Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experiment: Enable multi-value #1459

Draft
wants to merge 23 commits into
base: master
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
d718193
Experiment: Try enabling multi-value again
nomeata May 2, 2020
8127150
Bump wasmtime to 0.15
nomeata May 2, 2020
33246c9
Bump dfinity to enable multi-value
nomeata May 2, 2020
93374cb
-wasi-system-api: export _start
nomeata May 2, 2020
89bd890
Update test output (new wasmtime version)
nomeata May 2, 2020
001b54c
Stackrep stuff
nomeata May 2, 2020
4b8f57e
Merge branch 'master' of github.com:dfinity-lab/motoko into joachim/m…
nomeata May 5, 2020
fc0e3e6
Merge branch 'master' into joachim/multi-value
nomeata May 5, 2020
c48c46d
Merge branch 'master' into joachim/multi-value
nomeata May 7, 2020
fccfd76
Merge branch 'master' into joachim/multi-value
nomeata May 13, 2020
a211067
Switch branch name in dfinity
nomeata May 14, 2020
8c7f9f1
Merge branch 'master' of github.com:dfinity-lab/motoko into joachim/m…
nomeata Sep 7, 2020
1a385ed
Merge branch 'master' of github.com:dfinity-lab/motoko into joachim/m…
nomeata Sep 17, 2020
841cdd2
Bump dfinity
nomeata Sep 17, 2020
754a9a5
Merge branch 'master' into joachim/multi-value
nomeata Aug 25, 2021
0151993
Merge branch 'master' into joachim/multi-value
nomeata Aug 25, 2021
baf1250
Merge branch 'master' of github.com:dfinity/motoko into joachim/multi…
nomeata Aug 26, 2021
75f6d1a
Update command line flags
nomeata Aug 26, 2021
3fdb00b
Merge branch 'master' of github.com:dfinity/motoko into joachim/multi…
nomeata Oct 22, 2021
1b4a4f7
Merge branch 'master' of github.com:dfinity/motoko into joachim/multi…
nomeata Dec 12, 2021
ae36c8f
Simple multi-value test case
nomeata Dec 12, 2021
d4d854e
Merge remote-tracking branch 'origin/master' into joachim/multi-value
nomeata Nov 11, 2022
7c80e7f
update bench output
nomeata Nov 11, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/mo_config/flags.ml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ let print_depth = ref 2
let release_mode = ref false
let compile_mode = ref ICMode
let debug_info = ref false
let multi_value = ref false
let multi_value = ref true
let await_lowering = ref true
let async_lowering = ref true
let dump_parse = ref false
Expand Down
4 changes: 2 additions & 2 deletions test/bench/ok/heap-32.drun-run.ok
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
ingress Completed: Reply: 0x4449444c016c01b3c4b1f204680100010a00000000000000000101
ingress Completed: Reply: 0x4449444c0000
debug.print: (50_227, +91_377_860, 1_446_975_760)
debug.print: (50_070, +102_586_000, 1_520_068_314)
debug.print: (50_227, +91_377_860, 1_446_975_756)
debug.print: (50_070, +102_586_000, 1_520_068_310)
ingress Completed: Reply: 0x4449444c0000
12 changes: 6 additions & 6 deletions test/bench/ok/palindrome.drun-run.ok
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
ingress Completed: Reply: 0x4449444c016c01b3c4b1f204680100010a00000000000000000101
ingress Completed: Reply: 0x4449444c0000
debug.print: (true, +1_188, 13_519)
debug.print: (false, +1_188, 12_849)
debug.print: (false, +1_188, 13_509)
debug.print: (true, +868, 12_934)
debug.print: (false, +868, 11_878)
debug.print: (false, +868, 12_898)
debug.print: (true, +1_188, 13_517)
debug.print: (false, +1_188, 12_847)
debug.print: (false, +1_188, 13_507)
debug.print: (true, +868, 12_932)
debug.print: (false, +868, 11_876)
debug.print: (false, +868, 12_896)
ingress Completed: Reply: 0x4449444c0000
2 changes: 1 addition & 1 deletion test/run-drun/ok/multi-value.drun-run.ok
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
ingress Completed: Reply: 0x4449444c016c01b3c4b1f204680100010a00000000000000000101
ingress Completed: Reply: 0x4449444c0000
ingress Err: IC0505: Wasm module of canister rwlgt-iiaaa-aaaaa-aaaaa-cai is not valid: Failed to deserialize wasm module with Invalid or unknown value type 26
2 changes: 1 addition & 1 deletion test/run.sh
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ ACCEPT=no
DTESTS=no
IDL=no
PERF=no
WASMTIME_OPTIONS="--disable-cache"
WASMTIME_OPTIONS="--disable-cache --wasm-features multi-value"
WRAP_drun=$(realpath $(dirname $0)/drun-wrapper.sh)
WRAP_ic_ref_run=$(realpath $(dirname $0)/ic-ref-run-wrapper.sh)
SKIP_RUNNING=${SKIP_RUNNING:-no}
Expand Down