Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check CPSAsync and CPSAwait properly #2551

Merged
merged 4 commits into from
Jun 2, 2021
Merged

check CPSAsync and CPSAwait properly #2551

merged 4 commits into from
Jun 2, 2021

Conversation

crusso
Copy link
Contributor

@crusso crusso commented Jun 2, 2021

Salvage an IR check I implemented for the async optimization.

@crusso crusso requested a review from nomeata June 2, 2021 12:29
@dfinity-ci
Copy link

This PR does not affect the produced WebAssembly code.

src/ir_def/check_ir.ml Outdated Show resolved Hide resolved
src/ir_def/check_ir.ml Show resolved Hide resolved
@crusso
Copy link
Contributor Author

crusso commented Jun 2, 2021

Did not quite work with divergent await argumens, so porting more of original solution over that required annotating CPSAwait with the current continuation type.

@nomeata PTAL if you like

@crusso crusso merged commit e2691fd into master Jun 2, 2021
@crusso crusso deleted the claudio/check-ir-cps branch June 2, 2021 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants