Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update instructions for reporting compiler bugs #2585

Closed
wants to merge 1 commit into from

Conversation

paulyoung
Copy link
Contributor

Link to GitHub issues now that Motoko is open source.

Spotted here: https://forum.dfinity.org/t/motoko-compiler-bug/5095

Link to GitHub issues now that Motoko is open source.

Spotted here: https://forum.dfinity.org/t/motoko-compiler-bug/5095
@dfinity-ci
Copy link

This PR does not affect the produced WebAssembly code.

@paulyoung
Copy link
Contributor Author

Could someone help me understand what happened here?

It seems a bit odd that another PR was opened after this one with the same change which used the “fixes” keyword to close this one.

Is there something I should do differently next time? Thanks.

@ggreif
Copy link
Contributor

ggreif commented Jun 12, 2021

@paulyoung yes, GitHub semantically analyses certain phrases and performs the "obvious" actions. Not sure why @nomeata took the changes and chose not to merge these :-/

@paulyoung
Copy link
Contributor Author

Hi @ggreif!

I understand that GitHub does that, I'm just wondering if there was some problem with this PR that caused @nomeata to open #2586.

@ggreif
Copy link
Contributor

ggreif commented Jun 12, 2021

I think you did everything alright :-)

@kritzcreek
Copy link
Contributor

I think Joachim might've thought this was an issue rather than a PR?

Regardless, for now we'll need to open a PR from a branch on this repo, or we won't be able to run the full CI pipeline. We're working on fixing this pretty soon, but I think until that happens we basically can't merge PR's from forks.

@nomeata
Copy link
Collaborator

nomeata commented Jun 12, 2021

I think Joachim might've thought this was an issue rather than a PR?

Indeed that was the case!

Regardless, for now we'll need to open a PR from a branch on this repo, or we won't be able to run the full CI pipeline. We're working on fixing this pretty soon, but I think until that happens we basically can't merge PR's from forks.

And that's why I wasn't sad about my mistake :-)

@paulyoung
Copy link
Contributor Author

Good to know!

@paulyoung paulyoung deleted the patch-1 branch June 12, 2021 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants