-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update instructions for reporting compiler bugs #2585
Conversation
Link to GitHub issues now that Motoko is open source. Spotted here: https://forum.dfinity.org/t/motoko-compiler-bug/5095
This PR does not affect the produced WebAssembly code. |
Could someone help me understand what happened here? It seems a bit odd that another PR was opened after this one with the same change which used the “fixes” keyword to close this one. Is there something I should do differently next time? Thanks. |
@paulyoung yes, GitHub semantically analyses certain phrases and performs the "obvious" actions. Not sure why @nomeata took the changes and chose not to merge these :-/ |
I think you did everything alright :-) |
I think Joachim might've thought this was an issue rather than a PR? Regardless, for now we'll need to open a PR from a branch on this repo, or we won't be able to run the full CI pipeline. We're working on fixing this pretty soon, but I think until that happens we basically can't merge PR's from forks. |
Indeed that was the case!
And that's why I wasn't sad about my mistake :-) |
Good to know! |
Link to GitHub issues now that Motoko is open source.
Spotted here: https://forum.dfinity.org/t/motoko-compiler-bug/5095