Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reproduce #3057 #3058

Merged
merged 5 commits into from
Feb 15, 2022
Merged

Reproduce #3057 #3058

merged 5 commits into from
Feb 15, 2022

Conversation

ggreif
Copy link
Contributor

@ggreif ggreif commented Jan 12, 2022 •
edited
Loading

Reproduces the infinite recursion.

Also speeds up the normalisation by passing various -e to sed.

@ggreif ggreif marked this pull request as ready for review February 12, 2022 13:23
@ggreif ggreif changed the title reproduce #3057 Reproduce #3057 Feb 12, 2022
@ggreif
Copy link
Contributor Author

ggreif commented Feb 12, 2022

@crusso I am a bit split whether this should live in tests/fail, but I think this is not intended to fail. Rather it fails due to a bug now, but should be fixed some time.

@ggreif ggreif requested review from crusso and nomeata February 12, 2022 13:31
@github-actions
Copy link

Comparing from defd131 to 1b4cf72:
The produced WebAssembly code seems to be completely unchanged.

crusso
crusso approved these changes Feb 15, 2022
View reviewed changes
Copy link
Contributor

@crusso crusso left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we merge this or just leave it open until #3507 is fixed?

@ggreif
Copy link
Contributor Author

ggreif commented Feb 15, 2022

I'll merge. When fixing #3507 this must be touched. Null problemo.

@ggreif ggreif added the automerge-squash When ready, merge (using squash) label Feb 15, 2022
@mergify mergify bot merged commit 61883e8 into master Feb 15, 2022
@mergify mergify bot deleted the gabor/bug_3057 branch February 15, 2022 11:47
@mergify mergify bot removed the automerge-squash When ready, merge (using squash) label Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crusso crusso crusso approved these changes

@nomeata nomeata Awaiting requested review from nomeata

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ggreif @crusso