Gabor/arity #4620
Draft
Gabor/arity #4620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
but be sure to use the calling convention of the checker right now the supertype is returned, though!
use the same calling convention transform
ggreif
commented
Jul 17, 2024
| (Nat, Nat) -> ((Nat, Nat)) | ||
| cannot produce expected type | ||
| ((Nat, Nat)) -> ((Nat, Nat)) | ||
| issue-3318.mo:2.13-2.14: warning [M0194], unused identifier f (delete or rename to wildcard `_` or `_f`) |
There was a problem hiding this comment.
This test passes now, but should it? Needs thorough checking!
There was a problem hiding this comment.
What is issue #3318?
ggreif
commented
Jul 17, 2024
| @@ -637,6 +637,11 @@ and check_typ' env typ : T.typ = | |||
| let c, typs2 = as_codomT sort.it typ2 in | |||
| let ts1 = List.map (check_typ env') typs1 in | |||
| let ts2 = List.map (check_typ env') typs2 in | |||
| if (typ.at.left.file = "Xstdin") | |||
There was a problem hiding this comment.
remove this debug code
ggreif
commented
Jul 17, 2024
| let u, u' = | ||
| let open T in | ||
| if is_func t && is_func t' then | ||
| let transfer_arity from toh = match from, List.map normalize toh with |
There was a problem hiding this comment.
maybe we shouldn't normalise here, as it exposes (hidden) Tup, where none was before. We need the some tests, but also monomorphic ones to see if there are discrepancies.
ggreif
commented
Jul 17, 2024
| @@ -73,34 +73,34 @@ to argument of type | |||
| <V>V -> V | |||
| to produce result of type | |||
| () | |||
| because no instantiation of T__102 makes | |||
| <V>V -> V <: <U>T__102 -> U | |||
| because no instantiation of T__105 makes | |||
There was a problem hiding this comment.
Why did these numbers shift by 3?
ggreif
commented
Jul 17, 2024
| | _, [Tup ts] -> ts | ||
| | _, _ -> toh in | ||
| let s, c, tbs, ts1, ts2 = as_func t in | ||
| let dom, cod = transfer_arity ts1, transfer_arity ts2 in |
There was a problem hiding this comment.
Checking monomorphic lambdas uses as_domT/as_codomT, so maybe we should use it here too?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: a possibly wrong approach is in https://github.com/dfinity/motoko/tree/gabor/higher