-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug: issue-4625 repro #4659
base: master
Are you sure you want to change the base?
bug: issue-4625 repro #4659
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, maybe you can add the 3 missing newlines too.
Co-authored-by: Gabor Greif <gabor@dfinity.org>
Co-authored-by: Gabor Greif <gabor@dfinity.org>
Maybe this should be under |
I'm not sure how fixable this is. I wonder if design/IDL-Motoko.md is underspecified on how to translate Motoko/Candid references to type definitions, i.e. translate without or after expansion and that affects the translation of argument sequences. In addition, both Motoko Null and () map to the Candid null. so type X = () translates to type X = Null |
Non-dfx repro for issue #4625