chore: Upgrade RTS Dependencies #4677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 29, 2024
crusso
reviewed
Sep 10, 2024
* Patch Rust for shared Wasm libraries * Get rid of `musl` * Further simplify Wasm linking * Update benchmark results * No longer need `wasm-ld` patch * Update test result * Add distinction for Linux Ocaml build * Revert "No longer need `wasm-ld` patch" This reverts commit 3d0f34e. * Revert "Update test result" This reverts commit 8fc5c08. * Use patched wasm-ld during Rust build * Table offset must be at least 1 for Rust RTS * Adjust linker test result * Use bulk memory operations * Do not need `wasm-lld` patch with shared targets * Adjust expected test result * Adjust nix build script * Fix nix build script
|
Size compression is no longer needed for the specific Rust target backends. This is the latest perf diff on CI (locally repeated): |
|
According to the GC benchmark, it seems that this upgrade/cleanup even improves performance:
|
luc-blaeser
commented
Oct 9, 2024
ggreif
reviewed
Nov 25, 2024
ggreif
reviewed
Nov 25, 2024
ggreif
reviewed
Nov 25, 2024
ggreif
reviewed
Nov 25, 2024
ggreif
previously approved these changes
Nov 25, 2024
crusso
previously approved these changes
Nov 26, 2024
crusso
added a commit
to dfinity/motoko-base
that referenced
this pull request
Nov 29, 2024
Adjusting the base library for latest Motoko RTS changes: * Also test enhanced orthogonal persistence with Wasm Memory 64. * Be prepared for the RTS dependency upgrade dfinity/motoko#4677 Changes: The original Musl float formatter has been replaced by the Rust implementation with some subtle format changes: - Numbers are displayed with the actually defined precision, no longer truncating trailing zeros and potentially revealing existing numeric errors. - The exponent is printed with an explicit sign and multiple digits. - NaN is formatted differently, now `NaN`, while the NaN sign bit is omitted. - The hexadecimal float formatter is no longer supported (`Float.format(#hex)`). This is probably acceptable as it is rarely used. Once we have dfinity/motoko#4677 merged in Motoko `master`, then we can remove the backwards compatibility of float formatting in these tests. Backwards compatibility is here needed to make `motoko-base` tests pass with the old Motoko compiler version. --------- Co-authored-by: Claudio Russo <claudio@dfinity.org>
crusso
approved these changes
Nov 29, 2024
|
Thank you for reviewing, Claudio and Gabor! |
crusso
previously approved these changes
Nov 29, 2024
crusso
reviewed
Nov 29, 2024
revert default.nix change to adtgen
crusso
approved these changes
Nov 29, 2024
ggreif
pushed a commit
to dfinity/motoko-base
that referenced
this pull request
Dec 4, 2024
Adjusting the base library for latest Motoko RTS changes: * Also test enhanced orthogonal persistence with Wasm Memory 64. * Be prepared for the RTS dependency upgrade dfinity/motoko#4677 Changes: The original Musl float formatter has been replaced by the Rust implementation with some subtle format changes: - Numbers are displayed with the actually defined precision, no longer truncating trailing zeros and potentially revealing existing numeric errors. - The exponent is printed with an explicit sign and multiple digits. - NaN is formatted differently, now `NaN`, while the NaN sign bit is omitted. - The hexadecimal float formatter is no longer supported (`Float.format(#hex)`). This is probably acceptable as it is rarely used. Once we have dfinity/motoko#4677 merged in Motoko `master`, then we can remove the backwards compatibility of float formatting in these tests. Backwards compatibility is here needed to make `motoko-base` tests pass with the old Motoko compiler version. --------- Co-authored-by: Claudio Russo <claudio@dfinity.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrading Motoko RTS dependencies:
Special aspects:
dylink.0instead ofdylink.GOT.memfor RTS in the Motoko linker.emscripten: Use custom Rust targets .emscriptenby using custom Rust targets for generating PIC-relocatable Wasm.muslby using Rust builtins instead.musl: The output format ofNaNandinfinityhas changed. Moreover, one particular output format (hexadecimal float) is no longer supported. Updating the documentation and base library is needed.musl.Note:
nix-shellcrashes with a segmentation fault with this PR, you need to upgradenix. For this, you need to manually uninstall and re-installnix.