bugfix: bound subtyping depth to avoid reliance on unpredictable stack overflow #4798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Gabor Greif <gabor@dfinity.org>
…ions of the same constructor as related by subtyping
…ive OOM/stackoverflow
crusso
changed the title
…toko into claudio/type-check-loop-bound
crusso
commented
Dec 5, 2024
rvanasa
previously approved these changes
Dec 5, 2024
…toko into claudio/type-check-loop-bound
Yeah, it does. Added test. |
crusso
commented
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea is to fail fast and deterministically, especially in VSCode extension. OCaml stack overflow detection is unreliable and sometimes issues OOM, sometimes stack overflow.
Fixes #3057.