-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add .values()
alias for .vals()
#4876
Conversation
…values-alias-for-vals
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but make sure that we have at least one test exercising the original vals
accessor... See also #4882.
…ty/motoko into ryan/values-alias-for-vals
…values-alias-for-vals
Co-authored-by: Gabor Greif <gabor@dfinity.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks tike all mechanic changes, tests look good.
Makes it possible to write
x.values()
in place ofx.vals()
for an array orBlob
. This is motivated by the upcoming base library changes in this repository.values()
is used in place ofvals()
for a large number of popular PLs (JS, Python, Java, C#, Rust, Swift, Kotlin, etc.), so this change would enable developers and LLMs to better transfer knowledge from other languages.Progress:
.vals()
and.values()