-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split RTS into multiple files #589
Conversation
cherry-picked from #588
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Nits and suggestions only.
rts/Makefile
Outdated
$(CLANG) -c $(CLANG_FLAGS) $(TOMMATH_FLAGS) -I$(TOMMATHSRC) --std=c11 $< --output $@ | ||
|
||
RTS_WASM_O=$(patsubst %,_build/wasm/%.o,$(RTSFILES)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume you know the shorthand $(var:pattern=replacement)
syntax. These are nice candidates.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In Makefiles
? (The syntax you write I only know from bash…)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure Substitution references.
Co-Authored-By: Gabor Greif <ggreif@gmail.com>
Co-Authored-By: Gabor Greif <ggreif@gmail.com>
Co-Authored-By: Gabor Greif <ggreif@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool.
## Changelog for candid: Branch: master Commits: [dfinity/candid@067025a8...87f42eef](dfinity/candid@067025a...87f42ee) * [`87f42eef`](dfinity/candid@87f42ee) Update CODEOWNERS ([dfinity/candid#589](https://togithub.com/dfinity/candid/issues/589))
## Changelog for candid: Branch: master Commits: [dfinity/candid@067025a8...87f42eef](dfinity/candid@067025a...87f42ee) * [`87f42eef`](dfinity/candid@87f42ee) Update CODEOWNERS ([dfinity/candid#589](https://togithub.com/dfinity/candid/issues/589))
cherry-picked from #588