Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split RTS into multiple files #589

Merged
merged 6 commits into from
Jul 22, 2019
Merged

Split RTS into multiple files #589

merged 6 commits into from
Jul 22, 2019

Conversation

nomeata
Copy link
Collaborator

@nomeata nomeata commented Jul 22, 2019

cherry-picked from #588

@nomeata nomeata added the automerge-squash When ready, merge (using squash) label Jul 22, 2019
@nomeata nomeata requested a review from ggreif July 22, 2019 11:55
Copy link
Contributor

@ggreif ggreif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nits and suggestions only.

rts/Makefile Outdated
$(CLANG) -c $(CLANG_FLAGS) $(TOMMATH_FLAGS) -I$(TOMMATHSRC) --std=c11 $< --output $@

RTS_WASM_O=$(patsubst %,_build/wasm/%.o,$(RTSFILES))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume you know the shorthand $(var:pattern=replacement) syntax. These are nice candidates.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In Makefiles? (The syntax you write I only know from bash…)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@ggreif ggreif Jul 22, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rts/Makefile Outdated Show resolved Hide resolved
rts/Makefile Outdated Show resolved Hide resolved
rts/Makefile Outdated Show resolved Hide resolved
nomeata and others added 3 commits July 22, 2019 14:32
Co-Authored-By: Gabor Greif <ggreif@gmail.com>
Co-Authored-By: Gabor Greif <ggreif@gmail.com>
Co-Authored-By: Gabor Greif <ggreif@gmail.com>
@nomeata nomeata removed the automerge-squash When ready, merge (using squash) label Jul 22, 2019
Copy link
Contributor

@ggreif ggreif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool.

@nomeata nomeata merged commit 73717df into master Jul 22, 2019
@nomeata nomeata deleted the joachim/rts-split branch July 22, 2019 14:05
dfinity-bot added a commit that referenced this pull request Dec 17, 2024
## Changelog for candid:
Branch: master
Commits: [dfinity/candid@067025a8...87f42eef](dfinity/candid@067025a...87f42ee)

* [`87f42eef`](dfinity/candid@87f42ee) Update CODEOWNERS ([dfinity/candid⁠#589](https://togithub.com/dfinity/candid/issues/589))
mergify bot pushed a commit that referenced this pull request Dec 18, 2024
## Changelog for candid:
Branch: master
Commits: [dfinity/candid@067025a8...87f42eef](dfinity/candid@067025a...87f42ee)

* [`87f42eef`](dfinity/candid@87f42ee) Update CODEOWNERS ([dfinity/candid⁠#589](https://togithub.com/dfinity/candid/issues/589))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants