build: organize imports in ts and spec files with prettier #404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmattia
approved these changes
Feb 7, 2022
| @@ -30,6 +30,7 @@ | |||
| "postcss": "^8.4.5", | |||
| "postcss-load-config": "^3.1.1", | |||
| "prettier": "^2.5.0", | |||
| "prettier-plugin-organize-imports": "^2.3.4", | |||
There was a problem hiding this comment.
Out of curiosity: just adding the dep enables the plugin?
There was a problem hiding this comment.
yep, magic 🧙🏼♂️
from its README:
A plugin that makes Prettier organize your imports (i. e. sorts, combines and removes unused ones) using the organizeImports feature of the TypeScript language service API. This is the same as using the "Organize Imports" action in VS Code.
This was referenced Feb 8, 2022
peterpeterparker
added a commit
to dfinity/ic-js
that referenced
this pull request
Feb 9, 2022
# Motivation To ease the review of PR and to improve our DX, automatically organize and sort the `import`. # Changes - add [prettier-plugin-organize-imports](https://github.com/simonhaenisch/prettier-plugin-organize-imports) # Note We use the plugin in [nns-dapp](dfinity/nns-dapp#404) too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
To ease the review of PR and to improve our DX, automatically organize and sort the
importChanges
Note
.svelteyet but will do so in all other files (all.tsand.spec.tsfiles)